fix(relay/client): fail all log watchers in case of single stream failure #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
daemon1024
requested review from
achrefbensaad,
Aryan-sharma11,
DelusionalOptimist,
rksharma95 and
seswarrajan
daemon1024
force-pushed
the
fix-partial-failure-client-reconnection
branch
from
806cefe to
84e6056
Compare
…lure Switched to ErrorWaitGroups from simple waitgroups, so we can control behaviour of goroutine groups. Error Groups with Contexts, cancel context as soon as one of the sub goroutines return a non nil error. Added context handling inside Watch Functions so that context cancellation from error wait groups is handled. Signed-off-by: daemon1024 <[email protected]>
daemon1024
force-pushed
the
fix-partial-failure-client-reconnection
branch
from
84e6056 to
199418b
Compare
DelusionalOptimist
approved these changes
Apr 16, 2024
Aryan-sharma11
approved these changes
Apr 16, 2024
seswarrajan
approved these changes
Apr 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Switched to ErrorWaitGroups from simple waitgroups, so we can control behaviour of goroutine groups. Error Groups with Contexts, cancel context as soon as one of the sub goroutines return a non nil error. Added context handling inside Watch Functions so that context cancellation from error wait groups is handled.
This fixes the issue where one of the streams would error out, but the reconnection didn't happen because other streams are working as expected.